ignore vlan attachment API responses "422 Virtual network foo already…" #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasheddan
reviewed
Jun 11, 2021
| // Virtual network 1182 already unassigned" | ||
| func IsAlreadyDone(err error) bool { | ||
| if e, ok := err.(*packngo.ErrorResponse); ok && e.Response != nil { | ||
| return e.Response.StatusCode == http.StatusUnprocessableEntity && |
There was a problem hiding this comment.
Is status code 422 enough to identify this error?
There was a problem hiding this comment.
Good catch.
I am also checking the text included in the error message (the bold elements are being checked):
422 Unprocessable Entity
{"error":"Virtual Network 1234 already attached"}
This will also capture "Virtual Network 1234 already unattached"
(I was originally checking for the text in the wrong place, StatusCode vs errsInOne. Fixed in the latest commits).
… ..." Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
Signed-off-by: Marques Johansson <mjohansson@equinix.com>
displague
force-pushed
the
ignore-422-vlan-already
branch
from
6f55a79
to
89f2b16
Compare
|
hasheddan
approved these changes
Jun 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
During conformance testing, attachment resources would reach un unready state, despite being ready.
Checklist
I have:
make reviewableto ensure this PR is ready for review.